On 8/27/2018 9:48 PM, Honggang LI wrote: > From: Honggang Li <honli@xxxxxxxxxx> > > Issue was found by Coverity. > > Error: RESOURCE_LEAK (CWE-772): [#def14] > opensm-3.3.20/osmtest/osmtest.c:6364: alloc_fn: Storage is returned from allocation function "node_new". > opensm-3.3.20/osmtest/include/osmtest_subnet.h:116:2: alloc_fn: Storage is returned from allocation function "malloc". > opensm-3.3.20/osmtest/include/osmtest_subnet.h:116:2: var_assign: Assigning: "p_obj" = "malloc(288UL)". > opensm-3.3.20/osmtest/include/osmtest_subnet.h:118:3: noescape: Resource "p_obj" is not freed or pointed-to in function "memset". [Note: The source code implementation of the function has been overridden by a builtin model.] > opensm-3.3.20/osmtest/include/osmtest_subnet.h:119:2: return_alloc: Returning allocated memory "p_obj". > opensm-3.3.20/osmtest/osmtest.c:6364: var_assign: Assigning: "p_node" = storage returned from "node_new()". > opensm-3.3.20/osmtest/osmtest.c:6572: leaked_storage: Variable "p_node" going out of scope leaks the storage it points to. > |# 6570| Exit: > |# 6571| OSM_LOG_EXIT(&p_osmt->log); > |# 6572|-> return (status); > |# 6573| } > |# 6574| > > =========== > > Signed-off-by: Honggang Li <honli@xxxxxxxxxx> Thanks. Applied. -- Hal
