On Mon, Aug 27, 2018 at 08:44:16AM +0300, Leon Romanovsky wrote:
> From: Parav Pandit <parav@xxxxxxxxxxxx>
>
> While performing lookup in a pool, if entry is found, take the
> reference right there, instead of checking again outside the loop and
> save one branch.
>
> Signed-off-by: Parav Pandit <parav@xxxxxxxxxxxx>
> Reviewed-by: Daniel Jurgens <danielj@xxxxxxxxxxxx>
> Signed-off-by: Leon Romanovsky <leonro@xxxxxxxxxxxx>
Reviewed-by: Yuval Shaia <yuval.shaia@xxxxxxxxxx>
> ---
> drivers/infiniband/sw/rxe/rxe_pool.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/infiniband/sw/rxe/rxe_pool.c b/drivers/infiniband/sw/rxe/rxe_pool.c
> index c8598b91e454..36b53fb94a49 100644
> --- a/drivers/infiniband/sw/rxe/rxe_pool.c
> +++ b/drivers/infiniband/sw/rxe/rxe_pool.c
> @@ -450,13 +450,12 @@ void *rxe_pool_get_index(struct rxe_pool *pool, u32 index)
> node = node->rb_left;
> else if (elem->index < index)
> node = node->rb_right;
> - else
> + else {
> + kref_get(&elem->ref_cnt);
> break;
> + }
> }
>
> - if (node)
> - kref_get(&elem->ref_cnt);
> -
> out:
> read_unlock_irqrestore(&pool->pool_lock, flags);
> return node ? elem : NULL;
> --
> 2.14.4
>
