>-----Original Message----- >From: Jason Gunthorpe [mailto:jgg@xxxxxxxx] >Sent: Monday, August 20, 2018 6:55 PM >To: Dalessandro, Dennis <dennis.dalessandro@xxxxxxxxx> >Cc: dledford@xxxxxxxxxx; linux-rdma@xxxxxxxxxxxxxxx; Ruhl, Michael J ><michael.j.ruhl@xxxxxxxxx>; Marciniszyn, Mike ><mike.marciniszyn@xxxxxxxxx>; Leshner, Gary S <gary.s.leshner@xxxxxxxxx> >Subject: Re: [PATCH for-4.19] IB/hfi1: Invalid NUMA node information can >cause a divide by zero > >On Wed, Aug 15, 2018 at 10:54:49PM -0700, Dennis Dalessandro wrote: > >> +out: >> + /* >> + * Invalid PCI NUMA node information found, note it, and populate >> + * our database 1:1. >> + */ >> + pr_err("HFI: Invalid PCI NUMA node. Performance may be >affected\n"); >> + pr_err("HFI: System BIOS may need to be upgraded\n"); > >Is this right? The other pre_err's don't use the HFI: prefix, and I >thought we were getting away from that kernel wide? Hi Jason, I missed the fact that the other pr_err()s didn't have this string. Since this is happening the module_init() path, there isn't any device info, and I wanted to be explicit. If you would like me to remove I can rework the patch. Mike >Jason
