On Thu, Aug 09, 2018 at 10:40:30AM +0300, Leon Romanovsky wrote: > > There are lots of comments talking about the construction of the radix > > tree key, including the one you clipped above that directly says what > > the zero index is, and the larger comment at the top explaining that 0 > > is always used for something. > > > > Maybe it should be more explicit?? > > > > There are three 'identifiers' for each attribute: > > 1) The kernel enum value (ie something like > > UVERBS_ATTR_ALLOC_DM_HANDLE) > > This is a 16 bit value > > 2) The radix tree leaf key (called attr_key). This is the 16 bit > > value manipulated down to 6 bits, with 0 reserved > > 3) The bitmap/linear array index (called attr_bkey). This is the 16 bit > > value manipulated down to 6 bits, without 0 reserved. > > > > Would the above help in one of the comment blocks? > > I think that the best will be to have proper description under > Documentation/ folder. I have this in mind as a future project. It is quite a big job Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
