[bug report] iw_cxgb4: Support FW write completion WR

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Potnuri Bharat Teja,

The patch 94245f4ad9e1: "iw_cxgb4: Support FW write completion WR"
from Aug 2, 2018, leads to the following static checker warning:

	drivers/infiniband/hw/cxgb4/qp.c:651 build_rdma_write_cmpl()
	error: uninitialized symbol 'plen'.

drivers/infiniband/hw/cxgb4/qp.c
   636          wcwr->r3 = 0;
   637  
   638          /* SEND_INV SGL */
   639          if (wr->next->send_flags & IB_SEND_INLINE)
   640                  build_immd_cmpl(sq, &wcwr->u_cmpl.immd_src, wr->next);
   641          else
   642                  build_isgl((__be64 *)sq->queue, (__be64 *)&sq->queue[sq->size],
   643                             &wcwr->u_cmpl.isgl_src, wr->next->sg_list, 1, NULL);
   644  
   645          /* WRITE SGL */
   646          build_isgl((__be64 *)sq->queue, (__be64 *)&sq->queue[sq->size],
   647                     wcwr->u.isgl_src, wr->sg_list, wr->num_sge, &plen);
                                                                       ^^^^^
Smatch thinks build_isgl() can return -EMSGSIZE

   648  
   649          size = sizeof(*wcwr) + sizeof(struct fw_ri_isgl) +
   650                  wr->num_sge * sizeof(struct fw_ri_sge);
   651          wcwr->plen = cpu_to_be32(plen);
   652          *len16 = DIV_ROUND_UP(size, 16);

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux