> -----Original Message-----
> From: Leon Romanovsky <leon@xxxxxxxxxx>
> Sent: Tuesday, August 7, 2018 1:11 AM
> To: Parav Pandit <parav@xxxxxxxxxxxx>
> Cc: Doug Ledford <dledford@xxxxxxxxxx>; Jason Gunthorpe
> <jgg@xxxxxxxxxxxx>; RDMA mailing list <linux-rdma@xxxxxxxxxxxxxxx>; Yossi
> Itigin <yosefe@xxxxxxxxxxxx>
> Subject: Re: [PATCH rdma-next] IB/ucm: Initialize sgid request GID attribute
> pointer
>
> On Mon, Aug 06, 2018 at 09:25:13PM +0000, Parav Pandit wrote:
> >
> >
> > > -----Original Message-----
> > > From: Leon Romanovsky <leon@xxxxxxxxxx>
> > > Sent: Sunday, August 5, 2018 11:46 PM
> > > To: Doug Ledford <dledford@xxxxxxxxxx>; Jason Gunthorpe
> > > <jgg@xxxxxxxxxxxx>
> > > Cc: Parav Pandit <parav@xxxxxxxxxxxx>; RDMA mailing list <linux-
> > > rdma@xxxxxxxxxxxxxxx>; Yossi Itigin <yosefe@xxxxxxxxxxxx>; Leon
> > > Romanovsky <leonro@xxxxxxxxxxxx>
> > > Subject: [PATCH rdma-next] IB/ucm: Initialize sgid request GID
> > > attribute pointer
> > >
> > > From: Parav Pandit <parav@xxxxxxxxxxxx>
> > >
> > > sgid_attr is uninitialized on the stack, initialize it to NULL.
> > >
> > > Fixes: 398391071f25 ("IB/cm: Replace members of sa_path_rec with
> > > 'struct sgid_attr *'")
> > > Signed-off-by: Parav Pandit <parav@xxxxxxxxxxxx>
> > > Reviewed-by: Yossi Itigin <yosefe@xxxxxxxxxxxx>
> > > Signed-off-by: Leon Romanovsky <leonro@xxxxxxxxxxxx>
> > > ---
> > When this fix was written in middle of July, it was planned for for-rc and Fixes
> line was sufficient for 4.18 rc cycle.
> > But due to few limitations, it posted pretty late now. Leon mentioned that
> commit log doesn't qualify for late rc hence it is for-next.
> >
> > This fix is needed for for-rc otherwise user space may be able to crash the
> kernel on uninitialized stack value of sgid_attr.
> > Do we need v1 with additional line explaining that uninitialized pointer can
> crash kernel?
>
> Parav,
>
> You are fixing commit 398391071f25, which is in -next branch and doesn't exist
> in rdma-rc.
>
Ok. Sorry for the noise.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
