Re: [PATCH] osm_mesh.c: Improve one line of comment

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Aug 06, 2018 at 10:34:29PM +0800, Honggang LI wrote:
> From: Honggang Li <honli@xxxxxxxxxx>
> 
> Signed-off-by: Honggang Li <honli@xxxxxxxxxx>
> ---
>  opensm/osm_mesh.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/opensm/osm_mesh.c b/opensm/osm_mesh.c
> index 8f84e53d..073a21e5 100644
> --- a/opensm/osm_mesh.c
> +++ b/opensm/osm_mesh.c
> @@ -1038,7 +1038,7 @@ static void make_geometry(lash_t *p_lash, int sw)
>  
>  				if (!s2->node->axes[l2]) {
>  					/*
> -					 * set axis to opposite of s1->axes[i]
> +					 * set axis to opposite of s1->node->axes[i]
>  					 */
>  					s2->node->axes[l2] = opposite(seed, s1->node->axes[i]);

I believe it is better to delete the comment completely as it does not give
any extra insight over the c code.

>  					change++;
> -- 
> 2.14.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux