On Wednesday, August 08/01/18, 2018 at 04:25:17 +0530, Jason Gunthorpe wrote: > On Wed, Aug 01, 2018 at 12:48:27AM +0530, Potnuri Bharat Teja wrote: > > On Friday, July 07/27/18, 2018 at 02:40:31 +0530, Jason Gunthorpe wrote: > > > On Thu, Jul 26, 2018 at 02:16:00PM -0500, Steve Wise wrote: > > > > > > > > Most apps choose to put a BE value in here, but any other > > > > > fixed-memory-order value would be fine. > > > > > > > > My point was, the applications need to "know" what endianness their peer is, > > > > or both agree to put it in BE or LE. IE The Verbs API doesn't do this for > > > > them and convert from host BO to a standard protocol-defined byte order. > > > > > > Yes, of course. What was done wrong here is defining it as a u32 at > > > all, it really should have been > > > > > > uint8_t imm_data[4]; > > > > > > To make it clear it is just an opaque application controlled buffer. > > > > > Hi Jason, > > Does my v3 look good enough to get into for next branch? > > Did you run it through sparse/etc? I see Bart has sent fixes for the > last cxgb4 series.. Yes, I did check for sparse warnings. No warnings observed. -Bharat -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
