On Tue, Jul 31, 2018 at 11:17:47AM -0700, Kees Cook wrote: > On Tue, Jul 31, 2018 at 10:18 AM, Leon Romanovsky <leon@xxxxxxxxxx> wrote: > > On Tue, Jul 31, 2018 at 10:08:02AM -0700, Kees Cook wrote: > >> On Mon, Jul 9, 2018 at 10:54 AM, Kees Cook <keescook@xxxxxxxxxxxx> wrote: > >> > On Sun, Jul 8, 2018 at 11:44 AM, Jason Gunthorpe <jgg@xxxxxxxxxxxx> wrote: > >> >> On Sun, Jul 08, 2018 at 01:38:32PM +0300, Leon Romanovsky wrote: > >> >>> From: Jason Gunthorpe <jgg@xxxxxxxxxxxx> > >> >>> > >> >>> Add shift_overflow() helper to help driver authors to ensure that > >> >>> shift operand doesn't cause to overflow. > >> >>> > >> >>> Signed-off-by: Jason Gunthorpe <jgg@xxxxxxxxxxxx> > >> >>> Signed-off-by: Leon Romanovsky <leonro@xxxxxxxxxxxx> > >> >>> --- > >> >>> include/linux/overflow.h | 23 +++++++++++++++++++++++ > >> >>> 1 file changed, 23 insertions(+) > >> >> > >> >> Kees/Rasmus, if you are happy with this please ack, I can run it > >> >> through the RDMA tree. Thanks > >> > > >> > Going through RDMA is fine by me. I'll let Rasmus ack this, assuming > >> > the current threads resolve. :) > >> > >> Has this happened? I don't see the shift helper in linux-next yet. > > > > No, I was requested to rewrite patch with tests and I didn't have time > > to do so. Maybe someday, I will have enough time to do it, but don't see > > it is happening in near future. > > Oh, I thought I saw additions to test_overflow.c already in the series? Yes and I stated in the cover letter that they are good enough to progress with overflow macro check and close security breach, but Rasmus wasn't convinced about it. This was enough to stop this series. Thanks > > -Kees > > -- > Kees Cook > Pixel Security
Attachment:
signature.asc
Description: PGP signature
