On Fri, Jul 27, 2018 at 02:55:54PM +0800, Liuyixian (Eason) wrote: > > > On 2018/7/27 0:51, Jason Gunthorpe wrote: > > On Thu, Jul 19, 2018 at 08:23:01PM +0800, Yixian Liu wrote: > > > >> +static void hns_roce_set_qps_to_err(struct hns_roce_dev *hr_dev, u32 qpn) > >> +{ > >> + struct hns_roce_qp *qp; > >> + struct ib_qp_attr attr; > >> + int attr_mask; > >> + int ret; > >> + > >> + qp = __hns_roce_qp_lookup(hr_dev, qpn); > >> + if (!qp) { > >> + dev_warn(hr_dev->dev, "no qp can be found!\n"); > >> + return; > >> + } > >> + > >> + if (qp->ibqp.pd->uobject) { > > > > All the places in this patch using pd->uobject should be just > > qp->uobject > > > > There is no uobject member in the struct hns_roce_qp, > should I use qp->ibqp.uobject for all the places? Yes Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html