On Fri, 27 Jul 2018 at 13:52, Eric Dumazet <eric.dumazet@xxxxxxxxx> wrote:
>
>
>
> On 07/25/2018 03:20 PM, Anders Roxell wrote:
> > Build error, implicit declaration of function __inet6_ehashfn shows up
> > When RDS is enabled but not IPV6.
> > net/rds/connection.c: In function ‘rds_conn_bucket’:
> > net/rds/connection.c:67:9: error: implicit declaration of function ‘__inet6_ehashfn’; did you mean ‘__inet_ehashfn’? [-Werror=implicit-function-declaration]
> > hash = __inet6_ehashfn(lhash, 0, fhash, 0, rds_hash_secret);
> > ^~~~~~~~~~~~~~~
> > __inet_ehashfn
> >
> > Current code adds IPV6 as a depends on in config RDS.
> >
> > Fixes: eee2fa6ab322 ("rds: Changing IP address internal representation to struct in6_addr")
> > Signed-off-by: Anders Roxell <anders.roxell@xxxxxxxxxx>
> > ---
> > net/rds/Kconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/net/rds/Kconfig b/net/rds/Kconfig
> > index 41f75563b54b..607128f10bcd 100644
> > --- a/net/rds/Kconfig
> > +++ b/net/rds/Kconfig
> > @@ -1,7 +1,7 @@
> >
> > config RDS
> > tristate "The RDS Protocol"
> > - depends on INET
> > + depends on INET && CONFIG_IPV6
>
> You probably meant :
>
> depends on INET && IPV6
Hmm... Yes, I'll send out a new patch to fix it.
I'm sorry.
Cheers,
Anders
>
>
> > ---help---
> > The RDS (Reliable Datagram Sockets) protocol provides reliable,
> > sequenced delivery of datagrams over Infiniband or TCP.
> >
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
