Re: [PATCH 2/6] Cast poniter type

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jul 26, 2018 at 10:12:42AM -0600, Jason Gunthorpe wrote:
> > >                  from osm_vendor_ibumad.c:66:
> > > /usr/include/infiniband/umad.h:178:56: note: expected ‘__be64 *’ {aka ‘long long unsigned int *’} but argument is of type ‘ib_net64_t *’ {aka ‘long unsigned int *’}
> > >  int umad_get_ca_portguids(const char *ca_name, __be64 *portguids, int max);
> > >                                                 ~~~~~~~~^~~~~~~~~
> > > cc1: all warnings being treated as errors
> > 
> > When libibumad was moved into rdma-core, the type of the portguids
> > parameter for the umad_get_ca_portguids API was changed from uint64_t to
> > __be64 and this was thought to be safe because it was thought that these
> > types were the same but that appears not to be the case here ;-(
> 
> They are the same, this is just a somewhat expected warning.
> 
> If you insist on compiling with -Werror then these things have to be
> fixed, otherwise the warning is harmless.
> 
> The proper fix is likely to change ib_net64_t to __be64.

+1, I suggest to replace 'ib_net64_t' with '__be64'.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux