On Thu, Jul 26, 2018 at 07:35:49AM +0300, Leon Romanovsky wrote: > On Wed, Jul 25, 2018 at 08:35:17AM -0600, Jason Gunthorpe wrote: > > On Wed, Jul 25, 2018 at 08:37:03AM +0300, Leon Romanovsky wrote: > > > > > > Also, I would like to keep the specs consistently formatted according > > > > to clang-format with 'BinPackParameters: true', so I reflowed them as > > > > well. > > > > > > I'm using default VIM clang-format.py without anything in .clang-format. > > > Do you have an extra definitions there, except BinPackParameters? > > > > These days Linux includes a top level .clang-format that does a > > pretty good job. > > > > I have to manually switch BinPackParameters on when working with these > > specs to get the right indenting.. A pain, but maybe there is a better > > way someday.. > > I don't think that it is feasible to ask from people to change some > defaults only for patches that touch those specs. Any change in this > area will change formatting back. Eventually I think we might be able toadd a code comment to tell clang-format, but that would be down the road a bit.. > Jason, bottom line, I won't use BinPackParameters for my patches. Well, you can make sure the specs macro follows the required formatting code style by hand if you prefer.. But, I want to see them in this layout, so they are easier to maintain, not the haphazard layout we had before. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
