On Thu, Jul 26, 2018 at 10:09:32AM +0300, Leon Romanovsky wrote:
> From: Denis Drozdov <denisd@xxxxxxxxxxxx>
>
> The change of ipoib_ah data structure with adding "valid" flag and
> checks of ah->valid in ipoib_start_xmit affected multicast packet flow.
>
> Since the multicast flow doesn't invoke path_rec_start, "ah->valid" flag
> remains unset, so that ipoib_start_xmit end up with neigh_refresh_path
> instead of sending the packet using neigh.
>
> "ah->valid" has to be set in multicast send flow. As a result IPoIB
> starts sending packets via neigh immediately and eliminates 60sec delay
> of neigh keep alive interval.
>
> The typical example of this issue are two sequential arpings:
>
> arping 11.134.208.9 -> got response (mcast_send)
> arping 11.134.208.9 -> no response (ah->valid = 0)
>
> Fixes: fa9391dbad4b ("RDMA/ipoib: Update paths on CLIENT_REREG/SM_CHANGE events")
> Signed-off-by: Denis Drozdov <denisd@xxxxxxxxxxxx>
> Reviewed-by: Erez Shitrit <erezsh@xxxxxxxxxxxx>
> Reviewed-by: Feras Daoud <ferasda@xxxxxxxxxxxx>
> Signed-off-by: Leon Romanovsky <leonro@xxxxxxxxxxxx>
> ---
> drivers/infiniband/ulp/ipoib/ipoib_multicast.c | 1 +
> 1 file changed, 1 insertion(+)
>
Please ignore this patch.
Thanks
Attachment:
signature.asc
Description: PGP signature
