On 7/24/2018 10:49 AM, Jason Gunthorpe wrote: > On Mon, Jul 23, 2018 at 12:17:42PM -0400, Hal Rosenstock wrote: >> On 7/19/2018 10:50 PM, Honggang LI wrote: >>> From: Honggang Li <honli@xxxxxxxxxx> >>> >>> grep -r -l '\-D_BSD_SOURCE=1' | xargs -I {} sed -e 's/-D_BSD_SOURCE=1/-D_DEFAULT_SOURCE=1/' -i {} >> >> My understanding is that DEFAULT_SOURCE is glibc 2.19 or later and that glibc 2.19 or later doesn't warn if both BSD_SOURCE and DEFAULT_SOURCE are both defined. So shouldn't this define both ? >> >> grep -r -l '\-D_BSD_SOURCE=1' | xargs -I {} sed -e >> 's/-D_BSD_SOURCE=1/-D_BSD_SOURCE=1 -D_DEFAULT_SOURCE=1/' -i {} > > You should just use _GNU_SOURCE which turns on every extension. Revised version of Honggang's patch to follow shortly. -- Hal > Jason > -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html