> From: Jason Gunthorpe [mailto:jgg@xxxxxxxx] > Sent: Tuesday, July 24, 2018 12:25 AM > On Mon, Jul 23, 2018 at 05:57:51PM +0300, Yuval Bason wrote: > > + > > + /* Make sure that descriptors are written before we update > > + * producers. > > + */ > > + > > + udma_to_device_barrier(); > > + > > + struct rdma_srq_producers *virt_prod; > > + > > + virt_prod = srq->hw_srq.virt_prod_pair_addr; > > + virt_prod->sge_prod = htole32(hw_srq->sge_prod); > > + virt_prod->wqe_prod = htole32(hw_srq->wqe_prod); > > These are not mmio writes, so this should probaboy be > udma_ordering_write_barrier() ? Yes, will fix. Last comment got me confused, but now I get you previous comment and those barriers usages (hopefully). > > Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
