Re: [PATCH rdma-next v2 1/3] RDMA/core: Remove {create,destroy}_ah from mandatory verbs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Jul 15, 2018 at 02:28:09AM +0300, Kamal Heib wrote:
> {create,destroy}_ah aren't mandatory verbs, because not all providers
> are implementing them.

It is chicken-egg problem. The "MANDATORY" here means IBTA spec and not
implementation mandatory. IMHO or we are removing everything or we are
not removing parts.

>
> Signed-off-by: Kamal Heib <kamalheib1@xxxxxxxxx>
> ---
>  drivers/infiniband/core/device.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/infiniband/core/device.c b/drivers/infiniband/core/device.c
> index b8144f194777..db3b6271f09d 100644
> --- a/drivers/infiniband/core/device.c
> +++ b/drivers/infiniband/core/device.c
> @@ -105,8 +105,6 @@ static int ib_device_check_mandatory(struct ib_device *device)
>  		IB_MANDATORY_FUNC(query_pkey),
>  		IB_MANDATORY_FUNC(alloc_pd),
>  		IB_MANDATORY_FUNC(dealloc_pd),
> -		IB_MANDATORY_FUNC(create_ah),
> -		IB_MANDATORY_FUNC(destroy_ah),
>  		IB_MANDATORY_FUNC(create_qp),
>  		IB_MANDATORY_FUNC(modify_qp),
>  		IB_MANDATORY_FUNC(destroy_qp),
> --
> 2.14.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux