Re: [PATCH rdma-next] RDMA/i40w: Hold read semaphore while looking after VMA

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Jul 21, 2018 at 08:31:30AM -0500, Shiraz Saleem wrote:
> On Sun, Jul 01, 2018 at 10:36:24AM -0600, Leon Romanovsky wrote:
> > From: Leon Romanovsky <leonro@xxxxxxxxxxxx>
> > 
> > VMA lookup is supposed to be performed while mmap_sem is held.
> > 
> > Fixes: f26c7c83395b ("i40iw: Add 2MB page support")
> > Signed-off-by: Leon Romanovsky <leonro@xxxxxxxxxxxx>
> >
> Thanks for fixing this bug.
> 
> Acked-by: Shiraz Saleem <shiraz.saleem@xxxxxxxxx> 

This code in the driver all looks wrong to me, it should not rely on
the huge pages flag and it shouldn't do this VM walking.

Can you please fix it?

Thanks,
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux