Re: [PATCH v5 02/20] RDMA: Constify the argument of the work request conversion functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 7/18/2018 12:25 PM, Bart Van Assche wrote:
When posting a send work request, the work request that is posted is
not modified by any of the RDMA drivers. Make this explicit by
constifying most ib_send_wr pointers in RDMA transport drivers.

Signed-off-by: Bart Van Assche <bart.vanassche@xxxxxxx>
Reviewed-by: Sagi Grimberg <sagi@xxxxxxxxxxx>
Cc: Ariel Elior <Ariel.Elior@xxxxxxxxxx>
Cc: Dennis Dalessandro <dennis.dalessandro@xxxxxxxxx>
Cc: Devesh Sharma <devesh.sharma@xxxxxxxxxxxx>
Cc: Faisal Latif <faisal.latif@xxxxxxxxx>
Cc: Leon Romanovsky <leonro@xxxxxxxxxxxx>
Cc: Lijun Ou <oulijun@xxxxxxxxxx>
Cc: Michal Kalderon <Michal.Kalderon@xxxxxxxxxx>
Cc: Mike Marciniszyn <mike.marciniszyn@xxxxxxxxx>
Cc: Moni Shoua <monis@xxxxxxxxxxxx>
Cc: Parav Pandit <parav@xxxxxxxxxxxx>
Cc: Selvin Xavier <selvin.xavier@xxxxxxxxxxxx>
Cc: Somnath Kotur <somnath.kotur@xxxxxxxxxxxx>
Cc: Sriharsha Basavapatna <sriharsha.basavapatna@xxxxxxxxxxxx>
Cc: Steve Wise <swise@xxxxxxxxxxx>
Cc: Wei Hu(Xavier) <xavier.huwei@xxxxxxxxxx>
Cc: Yishai Hadas <yishaih@xxxxxxxxxxxx>
---
  drivers/infiniband/hw/bnxt_re/ib_verbs.c     | 18 ++++++------
  drivers/infiniband/hw/cxgb3/iwch_qp.c        | 20 ++++++-------
  drivers/infiniband/hw/cxgb4/qp.c             | 21 +++++++------
  drivers/infiniband/hw/hns/hns_roce_device.h  |  2 +-
  drivers/infiniband/hw/hns/hns_roce_hw_v2.c   |  4 +--
  drivers/infiniband/hw/mlx4/qp.c              | 25 ++++++++--------
  drivers/infiniband/hw/mlx5/mlx5_ib.h         |  2 +-
  drivers/infiniband/hw/mlx5/qp.c              | 31 ++++++++++----------
  drivers/infiniband/hw/mthca/mthca_qp.c       |  8 ++---
  drivers/infiniband/hw/nes/nes_verbs.c        |  3 +-
  drivers/infiniband/hw/ocrdma/ocrdma_verbs.c  | 12 ++++----
  drivers/infiniband/hw/qedr/qedr_roce_cm.c    |  4 +--
  drivers/infiniband/hw/qedr/verbs.c           |  7 +++--
  drivers/infiniband/hw/qib/qib_verbs.h        |  2 +-
  drivers/infiniband/hw/vmw_pvrdma/pvrdma_qp.c |  3 +-
  drivers/infiniband/sw/rdmavt/qp.c            |  4 +--
  drivers/infiniband/sw/rxe/rxe_verbs.c        |  8 ++---
  include/rdma/ib_verbs.h                      | 11 +++----
  18 files changed, 97 insertions(+), 88 deletions(-)

For qib and rdmavt looks OK to me. Thanks!

Reviewed-by: Dennis Dalessandro <dennis.dalessandro@xxxxxxxxx>




--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux