Re: tp_mib_stats?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 07/22/2018 05:37 AM, Steve Wise wrote:
> Hey Randy:
> 
>> -----Original Message-----
>> From: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
>> Sent: Sunday, July 22, 2018 12:21 AM
>> To: linux-rdma@xxxxxxxxxxxxxxx; Steve Wise <swise@xxxxxxxxxxx>
>> Subject: tp_mib_stats?
>>
>> in linux-next, drivers/infiniband/hw/cxgb3/iwch_provider.c contains:
>>
>> static int iwch_get_mib(struct ib_device *ibdev, struct rdma_hw_stats *stats,
>> 			u8 port, int index)
>> {
>> 	struct iwch_dev *dev;
>> 	struct tp_mib_stats m; ///// where is this struct defined?
>> 	int ret;
>>
> 
> It is defined in drivers/net/ethernet/chelsio/cxgb3/common.h

and -Idrivers/net/etherhet/chelsio/cxgb3 is used to find it as
"common.h".


>> which causes build errors:
>>
>> ../drivers/infiniband/hw/cxgb3/iwch_provider.c: In function 'iwch_get_mib':
>> ../drivers/infiniband/hw/cxgb3/iwch_provider.c:1272:22: error: storage size
>> of 'm' isn't known
>>   struct tp_mib_stats m;
>>                       ^
>>
>> and then there is this (typo):
>> ../drivers/infiniband/hw/cxgb3/iwch_provider.c:1305:80: warning: left-hand
>> operand of comma expression has no effect [-Wunused-value]
>>   stats->value[TCPINERRS] = ((u64)m.tcpRetransSeg_hi << 32) +
>> m.tcpRetransSeg_lo,
> 
> 
> Perhaps there is a missing dependency for iw_cxgb3 on cxgb3?

They are both =m (this is an allmodconfig build).

This is only failing on mips64.  It builds successfully on other arch-es,
so I think it's safe to chalk this up to a toolchain problem.

>> Just s/,/;/ here.

Thanks for your help.

-- 
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux