On Thu, 2018-07-19 at 09:43 -0400, Chuck Lever wrote: +AD4- +AD4- On Jul 18, 2018, at 12:25 PM, Bart Van Assche +ADw-Bart.VanAssche+AEA-wdc.com+AD4- wrote: +AD4- +AD4- +AD4- +AD4- Instead of declaring and passing a dummy 'bad+AF8-wr' pointer, pass NULL +AD4- +AD4- as third argument to ib+AF8-post+AF8-(send+AHw-recv+AHw-srq+AF8-recv)(). +AD4- +AD4- +AD4- +AD4- Signed-off-by: Bart Van Assche +ADw-bart.vanassche+AEA-wdc.com+AD4- +AD4- +AD4- Cc: Chuck Lever +ADw-chuck.lever+AEA-oracle.com+AD4- +AD4- +AD4- I guess the theory is that since ib+AF8-post+AF8Aew-send,recv+AH0- are declared static inline, +AD4- the compiler can see that the third argument is a constant NULL and optimize +AD4- away the conditional +ACI-bad+AF8-recv+AF8-wr ? : +ACY-dummy+ACI- at each call site. +AD4- +AD4- Reviewed-by: Chuck Lever +ADw-chuck.lever+AEA-oracle.com+AD4- Yes, I'm indeed assuming that the compiler will optimize out the ternary expression because ib+AF8-post+AF8Aew-send,recv+AH0- are declared inline. Thanks for the review+ACE- Bart.-- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
