On Tue, Jul 17, 2018 at 12:46 AM, Mark Bloch <markb@xxxxxxxxxxxx> wrote: >> From: Or Gerlitz [mailto:gerlitz.or@xxxxxxxxx] >> > If NIC RX flow tables support decap opertion, enable it on creation. >> opertion --> operation saw it? >> > If NIC TX flow tables support reformat opertion, enable it on creation. opertion --> operation >> What is the trigger to use the decap flag on RX table or encap flag on >> TX table? > It has no performance penalty to always enable that, so that's what I do if supported. I was not referring to performance, see below >> Please note that we have a short blanket w.r.t mutual usage by > FDB and NIC steering tables have different limitations, so encap/decap on NIC steering > have nothing to do with the limitations the FDB has with those operations. no! AFAIK it has to do, the FW maintains three states for encap(decap) NONE, FDB or NIC if the state is NIC, an FDB table can't be created with encap set, and the other way around, if the state is FDB, NIC TX table can't be created with encap set, etc. This is the short blanket I was referring too, you can check me. >> NIC vs e-Switch steering, did you consider to do that on demand? > > The flow table needs to be created with those flags set if we want to attach > decap/packet reformat action to it. BTW, there is no modify action for those bits > so that's why I'm doing it on creation. The question was if you can let the application tell you that they want to use rules with encap/decap, as we did in the devlink switchdev API (encap enabled) -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
