On Thu, 2018-07-12 at 10:30 -0400, Chuck Lever wrote: > Jason has previously suggested that because it is the common case > that callers pass a dummy third argument, the primary post APIs > should drop the third parameter. Maybe that can help simplify this > situation. Thanks for the reminder. I will look further into this. > > > diff --git a/net/sunrpc/xprtrdma/verbs.c b/net/sunrpc/xprtrdma/verbs.c > > > index 112a15abc4a4..02d8fdad12ff 100644 > > > --- a/net/sunrpc/xprtrdma/verbs.c > > > +++ b/net/sunrpc/xprtrdma/verbs.c > > > @@ -1516,7 +1516,8 @@ void > > > rpcrdma_post_recvs(struct rpcrdma_xprt *r_xprt, bool temp) > > > { > > > struct rpcrdma_buffer *buf = &r_xprt->rx_buf; > > > - struct ib_recv_wr *wr, *bad_wr; > > > + struct ib_recv_wr *wr; > > > + struct ib_recv_wr *bad_wr; > > If no type qualifier change is needed here, then perhaps this hunk > can be dropped. You are right, I will drop this hunk. Thanks, Bart. ��.n��������+%������w��{.n�����{���fk��ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f