On Wed, Jul 11, 2018 at 12:08:51PM -0600, Jason Gunthorpe wrote:
> On Wed, Jul 11, 2018 at 08:55:40PM +0300, Kamal Heib wrote:
> > The rdma core is taking care of return the right error code when
> > modify_ah() callback isn't supported by the driver provider.
> >
> > Fixes: fe2caefcdf58 ('RDMA/ocrdma: Add driver for Emulex OneConnect IBoE RDMA adapter')
> > Signed-off-by: Kamal Heib <kamalheib1@xxxxxxxxx>
> > ---
> > drivers/infiniband/hw/ocrdma/ocrdma_ah.c | 6 ------
> > drivers/infiniband/hw/ocrdma/ocrdma_ah.h | 1 -
> > drivers/infiniband/hw/ocrdma/ocrdma_main.c | 1 -
> > 3 files changed, 8 deletions(-)
>
> I would be very happy to see a patch that got all of these pointless
> functions across all of the drivers.
>
> ie 10s of grepping finds this one: pvrdma_modify_cq
>
> I know there are many, I keep seeing them..
>
> Jason
OK, I see your point.
I'll start prepare that patch.
Thanks,
Kamal
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
