On Mon, Jul 09, 2018 at 04:51:13PM +0300, Jan Dakinevich wrote: > For most cases it is enough to use common GFP_KERNEL flag. However, > there is one place with defined fallback path on unsuccessful allocation. > In this case it would be preferred to append on first allocation attempt > __GFP_NOWARN and __GFP_NORETRY flags to suppress possible warnings and > to shorten the path to the fallback in a case of memory pressure. > > Signed-off-by: Jan Dakinevich <jan.dakinevich@xxxxxxxxxxxxx> > --- > drivers/infiniband/hw/mlx4/cq.c | 2 +- > drivers/infiniband/hw/mlx4/qp.c | 6 ++++-- > drivers/infiniband/hw/mlx4/srq.c | 2 +- > drivers/net/ethernet/mellanox/mlx4/alloc.c | 12 ++++++------ > include/linux/mlx4/device.h | 2 +- > 5 files changed, 13 insertions(+), 11 deletions(-) > Thanks for the patch, however we are working on the patch to avoid second call to mlx4_buf_alloc() and it will eliminate the annoying WARN splat. Because it is in latest stages of internal review, NAK. Thanks
Attachment:
signature.asc
Description: PGP signature
