Re: [PATCH rdma-next] IB/mlx5: Honor cnt_set_id_valid flag instead of set_id

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jul 09, 2018 at 01:31:45PM -0600, Jason Gunthorpe wrote:
> On Sun, Jul 08, 2018 at 01:40:30PM +0300, Leon Romanovsky wrote:
> > From: Parav Pandit <parav@xxxxxxxxxxxx>
> >
> > It is incorrect to depend on set_id value to know if counters were
> > allocated or not. set_id_valid field is set to true when counters
> > were allocated. Therefore, use set_id_valid while deciding to
> > free counters.
> >
> > Cc: <stable@xxxxxxxxxxxxxxx> # 4.15
> > Fixes: aac4492ef23a ("IB/mlx5: Update counter implementation for dual port RoCE")
> > Signed-off-by: Parav Pandit <parav@xxxxxxxxxxxx>
> > Reviewed-by: Daniel Jurgens <danielj@xxxxxxxxxxxx>
> > Signed-off-by: Leon Romanovsky <leonro@xxxxxxxxxxxx>
> >  drivers/infiniband/hw/mlx5/main.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
>
> Applied to for-next, but confused why this is cc'd stable but not for-rc.

In addition to said by Parav. I'm taking into account when and how the
fix is found (code review, failing old test or new test e.t.c). Once fix
is below my arbitrary threshold, I'm sending it to -next. This is the
case for this fix.

The reason of stable@ is due to the fact that Parav fixed bug.

Thanks

>
> Jason

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux