On Mon, Jul 09, 2018 at 08:44:20PM +0000, Parav Pandit wrote: > > > > From: Jason Gunthorpe [mailto:jgg@xxxxxxxx] > > Sent: Monday, July 09, 2018 2:44 PM > > To: Leon Romanovsky <leon@xxxxxxxxxx> > > Cc: Doug Ledford <dledford@xxxxxxxxxx>; Parav Pandit > > <parav@xxxxxxxxxxxx>; RDMA mailing list <linux-rdma@xxxxxxxxxxxxxxx>; > > Leon Romanovsky <leonro@xxxxxxxxxxxx> > > Subject: Re: [PATCH rdma-next] IB/core: Simplify check for RoCE route resolve > > > > On Sun, Jul 08, 2018 at 01:41:17PM +0300, Leon Romanovsky wrote: > > > From: Parav Pandit <parav@xxxxxxxxxxxx> > > > > > > roce_resolve_route_from_path() resolves the route based on the > > > netdevice of the GID attribute, therefore there is no point in > > > checking again if the route is resolved matches the same interface it arrived. > > > > > > Signed-off-by: Parav Pandit <parav@xxxxxxxxxxxx> > > > Signed-off-by: Leon Romanovsky <leonro@xxxxxxxxxxxx> > > > drivers/infiniband/core/sa_query.c | 29 ++--------------------------- > > > 1 file changed, 2 insertions(+), 27 deletions(-) > > > > > > diff --git a/drivers/infiniband/core/sa_query.c > > > b/drivers/infiniband/core/sa_query.c > > > index 524c6fc69b67..9d6a89e4a9c5 100644 > > > +++ b/drivers/infiniband/core/sa_query.c > > > @@ -1232,8 +1232,6 @@ roce_resolve_route_from_path(struct ib_device > > *device, u8 port_num, > > > struct sa_path_rec *rec, > > > const struct ib_gid_attr *attr) { > > > > After this change the 'struct ib_device *device' argument to the function is not > > used, so I got rid of it too. > > > Thanks Jason. > port_num can be removed too. Done Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
