RE: [PATCH rdma-next] IB/mlx5: Honor cnt_set_id_valid flag instead of set_id

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




> -----Original Message-----
> From: Jason Gunthorpe [mailto:jgg@xxxxxxxx]
> Sent: Monday, July 09, 2018 2:32 PM
> To: Leon Romanovsky <leon@xxxxxxxxxx>
> Cc: Doug Ledford <dledford@xxxxxxxxxx>; Parav Pandit
> <parav@xxxxxxxxxxxx>; RDMA mailing list <linux-rdma@xxxxxxxxxxxxxxx>;
> Daniel Jurgens <danielj@xxxxxxxxxxxx>; Leon Romanovsky
> <leonro@xxxxxxxxxxxx>
> Subject: Re: [PATCH rdma-next] IB/mlx5: Honor cnt_set_id_valid flag instead of
> set_id
> 
> On Sun, Jul 08, 2018 at 01:40:30PM +0300, Leon Romanovsky wrote:
> > From: Parav Pandit <parav@xxxxxxxxxxxx>
> >
> > It is incorrect to depend on set_id value to know if counters were
> > allocated or not. set_id_valid field is set to true when counters were
> > allocated. Therefore, use set_id_valid while deciding to free
> > counters.
> >
> > Cc: <stable@xxxxxxxxxxxxxxx> # 4.15
> > Fixes: aac4492ef23a ("IB/mlx5: Update counter implementation for dual
> > port RoCE")
> > Signed-off-by: Parav Pandit <parav@xxxxxxxxxxxx>
> > Reviewed-by: Daniel Jurgens <danielj@xxxxxxxxxxxx>
> > Signed-off-by: Leon Romanovsky <leonro@xxxxxxxxxxxx>
> > drivers/infiniband/hw/mlx5/main.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Applied to for-next, but confused why this is cc'd stable but not for-rc.
I guess because the bug was not introduced in this rc cycle. But it may be wrong guess.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux