On Mon, Jul 09, 2018 at 12:04:42PM -0600, Jason Gunthorpe wrote:
> On Thu, Jul 05, 2018 at 12:52:49AM +0300, Kamal Heib wrote:
> > Make sure to check for "-EOPNOTSUPP" instead of "-ENOSYS" which is the
> > return code from ib_create_srq() and rdma_set_cq_moderation() in case
> > that they aren't supported.
> >
> > Signed-off-by: Kamal Heib <kamalheib1@xxxxxxxxx>
> > drivers/infiniband/ulp/ipoib/ipoib_cm.c | 2 +-
> > drivers/infiniband/ulp/ipoib/ipoib_ethtool.c | 2 +-
> > 2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/infiniband/ulp/ipoib/ipoib_cm.c b/drivers/infiniband/ulp/ipoib/ipoib_cm.c
> > index 7eb38775f948..f16ecd799ab0 100644
> > +++ b/drivers/infiniband/ulp/ipoib/ipoib_cm.c
> > @@ -1564,7 +1564,7 @@ static void ipoib_cm_create_srq(struct net_device *dev, int max_sge)
> >
> > priv->cm.srq = ib_create_srq(priv->pd, &srq_init_attr);
> > if (IS_ERR(priv->cm.srq)) {
> > - if (PTR_ERR(priv->cm.srq) != -ENOSYS)
> > + if (PTR_ERR(priv->cm.srq) != -EOPNOTSUPP)
> > pr_warn("%s: failed to allocate SRQ, error %ld\n",
> > priv->ca->name, PTR_ERR(priv->cm.srq));
> > priv->cm.srq = NULL;
>
> There are several drivers that use ENOSYS, did you audit every
> ib_create_srq implementation in drivers to make sure there was no
> ENOSYS returned?
>
> Jason
Thanks for your review, I'll double check.
Thanks,
Kamal
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
