On Mon, Jul 09, 2018 at 06:52:09PM +0300, Yishai Hadas wrote: > +struct mlx5dv_flow_matcher * > +mlx5dv_create_flow_matcher(struct ibv_context *context, > + struct mlx5dv_flow_matcher_attr *attr) > +{ > + DECLARE_COMMAND_BUFFER_LINK(cmd, MLX5_IB_OBJECT_FLOW_MATCHER, > + MLX5_IB_METHOD_FLOW_MATCHER_CREATE, > + 4, > + NULL); Why is this using the LINK varient of the macro? > +int mlx5dv_destroy_flow_matcher(struct mlx5dv_flow_matcher *flow_matcher) > +{ > + DECLARE_COMMAND_BUFFER(cmd, MLX5_IB_OBJECT_FLOW_MATCHER, > + MLX5_IB_METHOD_FLOW_MATCHER_DESTROY, > + 1); > + int ret; Why not like this? Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html