On Fri, 2018-07-06 at 20:02 +0000, Ruhl, Michael J wrote: > > -----Original Message----- > > From: linux-rdma-owner@xxxxxxxxxxxxxxx [mailto:linux-rdma- > > owner@xxxxxxxxxxxxxxx] On Behalf Of Bart Van Assche > > Sent: Friday, July 6, 2018 1:17 PM > > To: Jason Gunthorpe <jgg@xxxxxxxx> > > Cc: Doug Ledford <dledford@xxxxxxxxxx>; linux-rdma@xxxxxxxxxxxxxxx; Bart > > Van Assche <bart.vanassche@xxxxxxx>; Lijun Ou <oulijun@xxxxxxxxxx>; > > Wei Hu <xavier.huwei@xxxxxxxxxx> > > Subject: [PATCH 06/13] RDMA/hns: Declare work request pointers that are > > not modified const > > > > Signed-off-by: Bart Van Assche <bart.vanassche@xxxxxxx> > > Cc: Lijun Ou <oulijun@xxxxxxxxxx> > > Cc: Wei Hu(Xavier) <xavier.huwei@xxxxxxxxxx> > > --- > > drivers/infiniband/hw/hns/hns_roce_hw_v2.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/infiniband/hw/hns/hns_roce_hw_v2.c > > b/drivers/infiniband/hw/hns/hns_roce_hw_v2.c > > index d8c68db4497f..40cde6dc15d6 100644 > > --- a/drivers/infiniband/hw/hns/hns_roce_hw_v2.c > > +++ b/drivers/infiniband/hw/hns/hns_roce_hw_v2.c > > @@ -164,7 +164,8 @@ static int set_rwqe_data_seg(struct ib_qp *ibqp, struct > > ib_send_wr *wr, > > return 0; > > } > > > > -static int hns_roce_v2_post_send(struct ib_qp *ibqp, struct ib_send_wr *wr, > > +static int hns_roce_v2_post_send(struct ib_qp *ibqp, > > + struct ib_send_wr *wr, > > struct ib_send_wr **bad_wr) > > Was one of these supposed to be const? That's a good question. Initially I did not plan to declare these pointers const since I wasn't sure it would be doable to modify all ULPs that call ib_post_send(). I will have another look at this. Bart. ��.n��������+%������w��{.n�����{���fk��ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f
