RE: [PATCH] RDMA/rxe: Remove unreachable code from rxe_create_ah()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




> -----Original Message-----
> From: Bart Van Assche [mailto:bart.vanassche@xxxxxxx]
> Sent: Thursday, July 05, 2018 6:00 PM
> To: Jason Gunthorpe <jgg@xxxxxxxx>
> Cc: Doug Ledford <dledford@xxxxxxxxxx>; linux-rdma@xxxxxxxxxxxxxxx; Bart
> Van Assche <bart.vanassche@xxxxxxx>; Parav Pandit <parav@xxxxxxxxxxxx>;
> Leon Romanovsky <leonro@xxxxxxxxxxxx>
> Subject: [PATCH] RDMA/rxe: Remove unreachable code from rxe_create_ah()
> 
> Fixes: 47ec38666210 ("RDMA: Convert drivers to use sgid_attr instead of
> sgid_index")
> Signed-off-by: Bart Van Assche <bart.vanassche@xxxxxxx>
> Cc: Parav Pandit <parav@xxxxxxxxxxxx>
> Cc: Leon Romanovsky <leonro@xxxxxxxxxxxx>
> ---
>  drivers/infiniband/sw/rxe/rxe_verbs.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/infiniband/sw/rxe/rxe_verbs.c
> b/drivers/infiniband/sw/rxe/rxe_verbs.c
> index 1272903d0fe3..0d5f0ad3cd02 100644
> --- a/drivers/infiniband/sw/rxe/rxe_verbs.c
> +++ b/drivers/infiniband/sw/rxe/rxe_verbs.c
> @@ -255,8 +255,6 @@ static struct ib_ah *rxe_create_ah(struct ib_pd *ibpd,
>  	rxe_init_av(rxe, attr, &ah->av);
>  	return &ah->ibah;
> 
> -	rxe_drop_ref(pd);
> -	rxe_drop_ref(ah);
>  err1:
>  	return ERR_PTR(err);
>  }
With that err1 label is not needed. both failures can return ERR_PTR(err) and ERR_PTR(-ENOMEM);
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux