Re: [PATCH] IB/iser: set can_queue earlier to allow setting higher queue depth

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 6/28/2018 5:42 PM, Sagi Grimberg wrote:

diff --git a/drivers/infiniband/ulp/iser/iscsi_iser.c b/drivers/infiniband/ulp/iser/iscsi_iser.c
index 9a6434c31db2..61cc47da2fec 100644
--- a/drivers/infiniband/ulp/iser/iscsi_iser.c
+++ b/drivers/infiniband/ulp/iser/iscsi_iser.c
@@ -633,8 +633,8 @@ iscsi_iser_session_create(struct iscsi_endpoint *ep,
       */
      if (ep) {
          iser_conn = ep->dd_data;
-        max_cmds = iser_conn->max_cmds;
          shost->sg_tablesize = iser_conn->scsi_sg_tablesize;
+        shost->can_queue = min_t(u16, cmds_max, iser_conn->max_cmds);

can we move it up before the if/else and set it once ?

The different conditions has different min arguments... Its really old
tools support, maybe we can simply drop it instead of letting it rot
forever?

ohh I didn't see the different arguments..
I think we can keep it meanwhile to avoid from getting complains regarding competability.

code looks fine,
Reviewed-by: Max Gurtovoy <maxg@xxxxxxxxxxxx>


--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux