Re: ISER blk-mq tags

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Hi Sagi,

My apologies for not replaying sooner. This works except I think we need this additional change:

diff -Nupr old/iscsi_iser.c new/iscsi_iser.c
--- old/iscsi_iser.c	2018-06-26 13:26:12.540014585 -0400
+++ new/iscsi_iser.c	2018-06-26 13:26:39.499089983 -0400
@@ -680,7 +680,7 @@ iscsi_iser_session_create(struct iscsi_e
  		 shost->max_sectors);
cls_session = iscsi_session_setup(&iscsi_iser_transport, shost,
-					  cmds_max, 0,
+					  shost->can_queue, 0,
  					  sizeof(struct iscsi_iser_task),
  					  initial_cmdsn, 0);
  	if (!cls_session)

I do not know if this change makes sense or not, however, if I do not make this then the system locks up with this:

I guess it makes sense if the session was configured with cmds_max
higher than what iser can support and the iscsi task pool was larger
than the number of qp entries and mrs.
Currently iSER relies on not ever seeing more inflight tasks than what
it can support.

Added your change and sent it for inclusion.

Thanks for reporting!
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux