Re: [PATCH rdma-core] Update IBVERBS_PABI_VERSION to 19

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jun 26, 2018 at 02:27:49PM +0300, Leon Romanovsky wrote:
> From: Leon Romanovsky <leonro@xxxxxxxxxxxx>
> 
> The first patch to break the provider ABI since v18 was
> commit 611f133fc193 ("verbs: Introduce counters object
> and its create/destroy verbs") with many more after.
> 
> Signed-off-by: Leon Romanovsky <leonro@xxxxxxxxxxxx>
>  PR https://github.com/linux-rdma/rdma-core/pull/352
>  I need it to release rdma-core.
>  CMakeLists.txt             | 2 +-
>  debian/libibverbs1.symbols | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/CMakeLists.txt b/CMakeLists.txt
> index c17ab15b..a3dbfa46 100644
> +++ b/CMakeLists.txt
> @@ -60,7 +60,7 @@ set(PACKAGE_NAME "RDMA")
>  set(PACKAGE_VERSION "19.0")
>  # When this is changed the values in these files need changing too:
>  #   debian/libibverbs1.symbols
> -set(IBVERBS_PABI_VERSION "18")
> +set(IBVERBS_PABI_VERSION "19")
>  set(IBVERBS_PROVIDER_SUFFIX "-rdmav${IBVERBS_PABI_VERSION}.so")
> 
>  #-------------------------
> diff --git a/debian/libibverbs1.symbols b/debian/libibverbs1.symbols
> index 785868d9..c86e6bb3 100644
> +++ b/debian/libibverbs1.symbols
> @@ -1,7 +1,7 @@
>  libibverbs.so.1 libibverbs1 #MINVER#
>   IBVERBS_1.0@IBVERBS_1.0 1.1.6
>   IBVERBS_1.1@IBVERBS_1.1 1.1.6
> - (symver)IBVERBS_PRIVATE_18 18
> + (symver)IBVERBS_PRIVATE_19 19
>   ibv_ack_async_event@IBVERBS_1.0 1.1.6
>   ibv_ack_async_event@IBVERBS_1.1 1.1.6
>   ibv_ack_cq_events@IBVERBS_1.0 1.1.6

This hunk is needed too:

commit 121cd39c99fc2f0560cefbf9f854caa57b7a55f0
Author: Benjamin Drung <benjamin.drung@xxxxxxxxxxxxxxxx>
Date:   Mon May 7 13:52:24 2018 +0200

    debian: Let libibverbs1 18 break ibverbs-providers 17
    
    ibverbs-providers uses the private symbols of libibverbs1. Thus
    libibverbs1 will not work with an old version of ibverbs-providers
    if the private symbol version is bumped.
    
    Bump the ibverbs-providers version that libibverbs1 and
    ibverbs-providers use the same major version.
    
    Signed-off-by: Benjamin Drung <benjamin.drung@xxxxxxxxxxxxxxxx>
    Signed-off-by: Jason Gunthorpe <jgg@xxxxxxxxxxxx>

diff --git a/debian/control b/debian/control
index 2cca4420ff350c..a5443c51eb04bd 100644
--- a/debian/control
+++ b/debian/control
@@ -139,7 +139,7 @@ Section: libs
 Pre-Depends: ${misc:Pre-Depends}
 Depends: adduser, ${misc:Depends}, ${shlibs:Depends}
 Recommends: ibverbs-providers
-Breaks: ibverbs-providers (<< 17~)
+Breaks: ibverbs-providers (<< 18~)
 Description: Library for direct userspace use of RDMA (InfiniBand/iWARP)
  libibverbs is a library that allows userspace processes to use RDMA
  "verbs" as described in the InfiniBand Architecture Specification and
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux