RE: [PATCH v6 2/2] nvmet-rdma: support max(16KB, PAGE_SIZE) inline data

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




> -----Original Message-----
> From: Linux-nvme <linux-nvme-bounces@xxxxxxxxxxxxxxxxxxx> On Behalf Of
> Sagi Grimberg
> Sent: Tuesday, June 26, 2018 6:13 AM
> To: Steve Wise <swise@xxxxxxxxxxxxxxxxxxxxx>; axboe@xxxxxxxxx;
> hch@xxxxxx; keith.busch@xxxxxxxxx; linux-nvme@xxxxxxxxxxxxxxxxxxx
> Cc: linux-rdma@xxxxxxxxxxxxxxx; maxg@xxxxxxxxxxxx;
> dledford@xxxxxxxxxx; jgg@xxxxxxxxxxxx; parav@xxxxxxxxxxxx
> Subject: Re: [PATCH v6 2/2] nvmet-rdma: support max(16KB, PAGE_SIZE)
> inline data
> 
> 
> > -	pr_info("enabling port %d (%pISpcs)\n",
> > -		le16_to_cpu(port->disc_addr.portid), (struct sockaddr
> *)&addr);
> > +	pr_info("enabling port %d (%pISpcs) inline_data_size %d\n",
> > +		le16_to_cpu(port->disc_addr.portid), (struct sockaddr
> *)&addr,
> > +		port->inline_data_size);
> 
> We can lose the info here, its should be visible via configfs.
> 
> otherwise looks fine,
> 
> Reviewed-by: Sagi Grimberg <sagi@xxxxxxxxxxx>

Thanks Sagi.  

Hey Christoph, I think this is ready to merge.  Feel free to remove the
pr_info() if you agree.  Or I can repost one more time.

Steve.

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux