Hi Jason, sorry, I somehow missed this email. I quickly checked the patch and I did not see anything wrong. I am going to review it better later today and if I see anything wrong I will follow-up with a patch/fix. Thanks for the patches! /Chris -----Original Message----- From: Jason Gunthorpe <jgg@xxxxxxxx> Sent: Monday, June 25, 2018 1:40 PM To: linux-rdma@xxxxxxxxxxxxxxx Cc: Christian Benvenuti (benve) <benve@xxxxxxxxx> Subject: Re: [PATCH] IB/usnic: Update with bug fixes from core code On Wed, Jun 13, 2018 at 11:19:42AM -0600, Jason Gunthorpe wrote: > usnic has a modified version of the core codes' ib_umem_get() and > related, and the copy misses many of the bug fixes done over the years: > > Commit bc3e53f682d9 ("mm: distinguish between mlocked and pinned > pages") Commit 87773dd56d54 ("IB: ib_umem_release() should decrement mm->pinned_vm > from ib_umem_get") Commit 8494057ab5e4 > ("IB/uverbs: Prevent integer overflow in ib_umem_get > address arithmetic") Commit 8abaae62f3fd > ("IB/core: disallow registering 0-sized memory region") Commit > 66578b0b2f69 ("IB/core: don't disallow registering region starting > at 0x0") > Commit 53376fedb9da ("RDMA/core: not to set page dirty bit if it's already > set.") > Commit 8e907ed48827 ("IB/umem: Use the correct mm during > ib_umem_release") > > Signed-off-by: Jason Gunthorpe <jgg@xxxxxxxxxxxx> > --- > drivers/infiniband/hw/usnic/usnic_ib_verbs.c | 2 +- > drivers/infiniband/hw/usnic/usnic_uiom.c | 40 ++++++++++++++------ > drivers/infiniband/hw/usnic/usnic_uiom.h | 5 ++- > 3 files changed, 33 insertions(+), 14 deletions(-) I guess we don't have any maintainers from cisco anymore? Applied to for-next Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html