> -----Original Message----- > From: Jason Gunthorpe [mailto:jgg@xxxxxxxx] > Sent: Monday, June 18, 2018 12:11 PM > To: Leon Romanovsky <leon@xxxxxxxxxx> > Cc: Doug Ledford <dledford@xxxxxxxxxx>; Parav Pandit > <parav@xxxxxxxxxxxx>; RDMA mailing list <linux-rdma@xxxxxxxxxxxxxxx>; > Leon Romanovsky <leonro@xxxxxxxxxxxx> > Subject: Re: [PATCH rdma-next] IB/core: Do not attempt to free GID entry which > has unbalanced get/put > > On Tue, Jun 12, 2018 at 07:29:23PM +0300, Leon Romanovsky wrote: > > From: Parav Pandit <parav@xxxxxxxxxxxx> > > > > When releasing GID table in release_gid_table(), there must not be any > > stale reference to a GID table entry. > > All GID entries must be freed when ib_cache_cleanup_one() completes. > > If a GID table entry has reference leak (unbalanced get/put), do not > > attempt to free such GID table entry. > > > > Fixes: 5198d83df9f6 ("IB/core: Introduce GID entry reference counts") > > Signed-off-by: Parav Pandit <parav@xxxxxxxxxxxx> > > Signed-off-by: Leon Romanovsky <leonro@xxxxxxxxxxxx> > > --- > > drivers/infiniband/core/cache.c | 14 +++++++++----- > > 1 file changed, 9 insertions(+), 5 deletions(-) > > I squashed this into the patch it is fixing since for-next is stil WIP, it will be real > for-next today. Thanks Jason. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html