On 6/7/2018 4:02 PM, Steve Wise wrote:
This patch replaces the ib_device_attr.max_sge with max_send_sge and max_recv_sge. It allows ulps to take advantage of devices that have very different send and recv sge depths. For example cxgb4 has a max_recv_sge of 4, yet a max_send_sge of 16. Splitting out these attributes allows much more efficient use of the SQ for cxgb4 with ulps that use the RDMA_RW API. Consider a large RDMA WRITE that has 16 scattergather entries. With max_sge of 4, the ulp would send 4 WRITE WRs, but with max_sge of 16, it can be done with 1 WRITE WR. Cc: Selvin Xavier <selvin.xavier@xxxxxxxxxxxx> Cc: Devesh Sharma <devesh.sharma@xxxxxxxxxxxx> Cc: Somnath Kotur <somnath.kotur@xxxxxxxxxxxx> Cc: Sriharsha Basavapatna <sriharsha.basavapatna@xxxxxxxxxxxx> Cc: Dennis Dalessandro <dennis.dalessandro@xxxxxxxxx> Cc: Mike Marciniszyn <mike.marciniszyn@xxxxxxxxx> Cc: Lijun Ou <oulijun@xxxxxxxxxx> Cc: Wei Hu(Xavier) <xavier.huwei@xxxxxxxxxx> Cc: Faisal Latif <faisal.latif@xxxxxxxxx> Cc: Shiraz Saleem <shiraz.saleem@xxxxxxxxx> Cc: Yishai Hadas <yishaih@xxxxxxxxxxxx> Cc: Leon Romanovsky <leonro@xxxxxxxxxxxx> Cc: Adit Ranadive <aditr@xxxxxxxxxx> Cc: VMware PV-Drivers <pv-drivers@xxxxxxxxxx> Cc: Moni Shoua <monis@xxxxxxxxxxxx> Cc: Sagi Grimberg <sagi@xxxxxxxxxxx> Cc: Christoph Hellwig <hch@xxxxxx> Cc: Santosh Shilimkar <santosh.shilimkar@xxxxxxxxxx> Cc: Steve French <sfrench@xxxxxxxxx> Cc: Chuck Lever <chuck.lever@xxxxxxxxxx> Acked-by: Sagi Grimberg <sagi@xxxxxxxxxxx> Acked-by: Christoph Hellwig <hch@xxxxxx> Acked-by: Selvin Xavier <selvin.xavier@xxxxxxxxxxxx> Acked-by: Shiraz Saleem <shiraz.saleem@xxxxxxxxx> Signed-off-by: Steve Wise <swise@xxxxxxxxxxxxxxxxxxxxx>
Looks good from qib, hfi1, and rdmavt perspective. Acked-by: Dennis Dalessandro <dennis.dalessandro@xxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html