On Tue, Jun 12, 2018 at 11:40 AM Hannes Reinecke <hare@xxxxxxx> wrote:
>
> On Tue, 12 Jun 2018 11:06:15 +0300
> Moni Shoua <monis@xxxxxxxxxxxx> wrote:
>
> > On Tue, Jun 12, 2018 at 10:35 AM Hannes Reinecke <hare@xxxxxxx> wrote:
> > >
> > > When using the module option 'add' during modprobe the module will
> > > crash as the option is evaluated before the module itself is
> > > initialized. So return an error when rxe_param_set_add() is called
> > > before the module is initialized.
> > >
> > > Signed-off-by: Hannes Reinecke <hare@xxxxxxxx>
> > > ---
> > > drivers/infiniband/sw/rxe/rxe.c | 6 ++++++
> > > drivers/infiniband/sw/rxe/rxe.h | 2 ++
> > > drivers/infiniband/sw/rxe/rxe_sysfs.c | 5 +++++
> > > 3 files changed, 13 insertions(+)
> > >
> > > diff --git a/drivers/infiniband/sw/rxe/rxe.c
> > > b/drivers/infiniband/sw/rxe/rxe.c index 7121e1b1eb89..53279d82e5cc
> > > 100644 --- a/drivers/infiniband/sw/rxe/rxe.c
> > > +++ b/drivers/infiniband/sw/rxe/rxe.c
> > > @@ -39,6 +39,8 @@ MODULE_AUTHOR("Bob Pearson, Frank Zago, John
> > > Groves, Kamal Heib"); MODULE_DESCRIPTION("Soft RDMA transport");
> > > MODULE_LICENSE("Dual BSD/GPL");
> > >
> > > +bool rxe_init_done = false;
> > > +
> > > /* free resources for all ports on a device */
> > > static void rxe_cleanup_ports(struct rxe_dev *rxe)
> > > {
> > > @@ -354,6 +356,8 @@ static int __init rxe_module_init(void)
> > > if (err)
> > > return err;
> > >
> > > + rxe_init_done = true;
> > > +
> > > pr_info("loaded\n");
> > > return 0;
> > > }
> > > @@ -364,6 +368,8 @@ static void __exit rxe_module_exit(void)
> > > rxe_net_exit();
> > > rxe_cache_exit();
> > >
> > > + rxe_init_done = false;
> > why not earlier?
>
> Because it's impossible to call 'modprobe' while an 'rmmod' is running;
> they are serialized against each other so we can be sure the module is
> fully unloaded before modprobe is run again.
>
but still, you don't want any add operations to start when rmmod
started. In fact, I think that the rmmod flow might be racy and you'd
like to handle it with more care.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
