On Thu, Jun 07, 2018 at 02:32:52AM -0400, Zhu Yanjun wrote: > In rxe_send, when network_type is not RDMA_NETWORK_IPV4 or > RDMA_NETWORK_IPV6, skb is freed and -EINVAL is returned. > Then rxe_xmit_packet will return -EINVAL, too. In rxe_requester, > this skb is double freed. > In rxe_requester, kfree_skb is needed only after fill_packet fails. > So kfree_skb is moved from label err to test fill_packet. > > Fixes: 5793b46 ("IB/rxe: remove unnecessary skb_clone in xmit") > Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > CC: Srinivas Eeda <srinivas.eeda@xxxxxxxxxx> > CC: Junxiao Bi <junxiao.bi@xxxxxxxxxx> > Signed-off-by: Zhu Yanjun <yanjun.zhu@xxxxxxxxxx> > Reviewed-by: Leon Romanovsky <leonro@xxxxxxxxxxxx> > --- > V1->V2: add the reporter > --- > drivers/infiniband/sw/rxe/rxe_req.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied to for-rc, thanks Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html