Hi Long, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on v4.17-rc6] [cannot apply to cifs/for-next next-20180601] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Long-Li/CIFS-Add-direct-I-O-support/20180602-130240 config: i386-randconfig-x000-201821 (attached as .config) compiler: gcc-7 (Debian 7.3.0-16) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=i386 All warnings (new ones prefixed by >>): In file included from include/linux/kernel.h:14:0, from include/linux/list.h:9, from include/linux/wait.h:7, from include/linux/wait_bit.h:8, from include/linux/fs.h:6, from fs/cifs/file.c:24: fs/cifs/file.c: In function 'cifs_direct_readv': include/linux/kern_levels.h:5:18: warning: format '%lu' expects argument of type 'long unsigned int', but argument 4 has type 'size_t {aka unsigned int}' [-Wformat=] #define KERN_SOH "\001" /* ASCII Start Of Header */ ^ include/linux/printk.h:136:10: note: in definition of macro 'no_printk' printk(fmt, ##__VA_ARGS__); \ ^~~ include/linux/kern_levels.h:15:20: note: in expansion of macro 'KERN_SOH' #define KERN_DEBUG KERN_SOH "7" /* debug-level messages */ ^~~~~~~~ include/linux/printk.h:342:12: note: in expansion of macro 'KERN_DEBUG' no_printk(KERN_DEBUG pr_fmt(fmt), ##__VA_ARGS__) ^~~~~~~~~~ >> fs/cifs/cifs_debug.h:82:3: note: in expansion of macro 'pr_debug' pr_debug(fmt, ##__VA_ARGS__); \ ^~~~~~~~ fs/cifs/file.c:3346:4: note: in expansion of macro 'cifs_dbg' cifs_dbg(VFS, ^~~~~~~~ fs/cifs/file.c:3348:20: note: format string is defined here " iov_offset %lu count %lu\n", ~~^ %u In file included from include/linux/kernel.h:14:0, from include/linux/list.h:9, from include/linux/wait.h:7, from include/linux/wait_bit.h:8, from include/linux/fs.h:6, from fs/cifs/file.c:24: include/linux/kern_levels.h:5:18: warning: format '%lu' expects argument of type 'long unsigned int', but argument 5 has type 'size_t {aka unsigned int}' [-Wformat=] #define KERN_SOH "\001" /* ASCII Start Of Header */ ^ include/linux/printk.h:136:10: note: in definition of macro 'no_printk' printk(fmt, ##__VA_ARGS__); \ ^~~ include/linux/kern_levels.h:15:20: note: in expansion of macro 'KERN_SOH' #define KERN_DEBUG KERN_SOH "7" /* debug-level messages */ ^~~~~~~~ include/linux/printk.h:342:12: note: in expansion of macro 'KERN_DEBUG' no_printk(KERN_DEBUG pr_fmt(fmt), ##__VA_ARGS__) ^~~~~~~~~~ >> fs/cifs/cifs_debug.h:82:3: note: in expansion of macro 'pr_debug' pr_debug(fmt, ##__VA_ARGS__); \ ^~~~~~~~ fs/cifs/file.c:3346:4: note: in expansion of macro 'cifs_dbg' cifs_dbg(VFS, ^~~~~~~~ fs/cifs/file.c:3348:30: note: format string is defined here " iov_offset %lu count %lu\n", ~~^ %u vim +/pr_debug +82 fs/cifs/cifs_debug.h f2f176b4 Aurelien Aptel 2018-04-10 73 ^1da177e Linus Torvalds 2005-04-16 74 /* ^1da177e Linus Torvalds 2005-04-16 75 * debug OFF ^1da177e Linus Torvalds 2005-04-16 76 * --------- ^1da177e Linus Torvalds 2005-04-16 77 */ ^1da177e Linus Torvalds 2005-04-16 78 #else /* _CIFS_DEBUG */ f96637be Joe Perches 2013-05-04 79 #define cifs_dbg(type, fmt, ...) \ bde98197 Joe Perches 2012-12-05 80 do { \ bde98197 Joe Perches 2012-12-05 81 if (0) \ 0b456f04 Andy Shevchenko 2014-08-27 @82 pr_debug(fmt, ##__VA_ARGS__); \ bde98197 Joe Perches 2012-12-05 83 } while (0) f96637be Joe Perches 2013-05-04 84 #endif ^1da177e Linus Torvalds 2005-04-16 85 :::::: The code at line 82 was first introduced by commit :::::: 0b456f04bcdf5b1151136adaada158bfc26f1be7 cifs: convert printk(LEVEL...) to pr_<level> :::::: TO: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> :::::: CC: Steve French <steve.french@xxxxxxxxxxxxxxx> --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
Attachment:
.config.gz
Description: application/gzip
