On 05/31/2018 02:54 AM, Michal Hocko wrote:
> On Tue 29-05-18 23:49:59, Eric Dumazet wrote:
>>
>>
>> On 05/29/2018 11:44 PM, Eric Dumazet wrote:
>>
>>>
>>> And I will add this simple fix, this really should address your initial concern much better.
>>>
>>> @@ -99,6 +100,8 @@ static int mlx4_alloc_icm_pages(struct scatterlist *mem, int order,
>>> {
>>> struct page *page;
>>>
>>> + if (order)
>>> + gfp_mask |= __GFP_NORETRY;
>>
>> and also gfp_mask &= ~__GFP_DIRECT_RECLAIM
>
> JFTR the latter one makes __GFP_NORETRY pointless. Non sleeping allocations
> are not retrying.
Hi Michal
Since when this rule is applied ?
These GFP flags change all the time, I suggest mm experts to cleanup existing call sites ?
I merely copied/pasted from alloc_skb_with_frags() :/
Thanks !
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
