From: Parav Pandit <parav@xxxxxxxxxxxx>
When GID entry is invalid, currently EAGAIN (try again) is returned.
This is incorrect, there is nothing that will make this GID entry
valid again after sometime.
Therefore return EINVAL which also makes any existing code to avoid
any complains such as ibv_query_gid_type() API of libibverbs user
space library.
Fixes: 03db3a2d81e6 ("IB/core: Add RoCE GID table management")
Reviewed-by: Daniel Jurgens <danielj@xxxxxxxxxxxx>
Signed-off-by: Parav Pandit <parav@xxxxxxxxxxxx>
Signed-off-by: Leon Romanovsky <leonro@xxxxxxxxxxxx>
---
drivers/infiniband/core/cache.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/infiniband/core/cache.c b/drivers/infiniband/core/cache.c
index 77d190d91f1a..e057ac368eed 100644
--- a/drivers/infiniband/core/cache.c
+++ b/drivers/infiniband/core/cache.c
@@ -645,7 +645,7 @@ static int __ib_cache_gid_get(struct ib_device *ib_dev, u8 port, int index,
return -EINVAL;
if (!is_gid_entry_valid(table->data_vec[index]))
- return -EAGAIN;
+ return -EINVAL;
memcpy(gid, &table->data_vec[index]->attr.gid, sizeof(*gid));
if (attr) {
--
2.14.3
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
