On 5/23/2018 12:48 PM, Parav Pandit wrote:
- log_pmtu = ah->log_pmtu;
+ log_pmtu = ilog2(ah->pmtu);
I don’t know if UD is widely used in IPoIB or not.
But won't you have any performance impact by doing ilog2 on every work request?
Just curious.
It might just find more use with a larger MTU that allows better
performance.
As to the ilog2 impact, it shouldn't be bad because while this is in the
data path, it's not in the "hot" data path.
+
+static inline int rdma_mtu_enum_to_int(struct ib_device *device, u8 port,
+ int mtu)
+{
+ if (rdma_core_cap_opa_port(device, port))
+ return opa_mtu_enum_to_int((enum opa_mtu) mtu);
+ else
+ return ib_mtu_enum_to_int((enum ib_mtu) mtu); }
+
Above rdma function needs kdoc comment block, mainly to describe what is mtu as its typecasted internally.
Sounds reasonable. We'll touch that up and send a v2.
-Denny
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
