On Mon, 2018-05-21 at 17:16 +0000, Calciano, Jess wrote: > > Does the following patch help: "[PATCH] sd: Increase SCSI disk probing concurrency" > > (https://www.spinics.net/lists/linux-scsi/msg115657.html)? > > The patch applied with no problems, but there's a compile error in scsi_pm.c. Is there maybe a prereq patch we need? > I tried it against the latest from https://github.com/torvalds/linux (4.17.0_rc5+) as well as one of our internal test kernels (based on 4.17.0_rc1+), and both resulted in the same failure. > > Here's the error: > > # make rpm > ...<snip>... > CC drivers/scsi/scsi.o > CC drivers/scsi/hosts.o > CC drivers/scsi/scsi_ioctl.o > CC drivers/scsi/scsicam.o > CC drivers/scsi/scsi_error.o > CC drivers/scsi/scsi_lib.o > CC drivers/scsi/scsi_common.o > CC drivers/scsi/constants.o > CC drivers/scsi/scsi_lib_dma.o > CC drivers/scsi/scsi_scan.o > CC drivers/scsi/scsi_sysfs.o > CC drivers/scsi/scsi_devinfo.o > CC drivers/scsi/scsi_netlink.o > CC drivers/scsi/scsi_sysctl.o > CC drivers/scsi/scsi_proc.o > CC drivers/scsi/scsi_debugfs.o > CC drivers/scsi/scsi_trace.o > CC drivers/scsi/scsi_logging.o > CC drivers/scsi/scsi_pm.o > drivers/scsi/scsi_pm.c: In function 'scsi_bus_prepare': > drivers/scsi/scsi_pm.c:177:10: error: 'struct scsi_driver' has no member named 'sync' > if (drv->sync) > ^ > drivers/scsi/scsi_pm.c:178:7: error: 'struct scsi_driver' has no member named 'sync' > drv->sync(dev); > ^ > make[4]: *** [drivers/scsi/scsi_pm.o] Error 1 > make[3]: *** [drivers/scsi] Error 2 > make[2]: *** [drivers] Error 2 > error: Bad exit status from /var/tmp/rpm-tmp.xdBh56 (%build) > > > RPM build errors: > Bad exit status from /var/tmp/rpm-tmp.xdBh56 (%build) > make[1]: *** [rpm-pkg] Error 1 > make: *** [rpm-pkg] Error 2 Hello Jess, Did you apply the entire patch? From the end of https://www.spinics.net/lists/linux-scsi/msg115657.html: diff --git a/include/scsi/scsi_driver.h b/include/scsi/scsi_driver.h index fae8b465233e..78173b6d305a 100644 --- a/include/scsi/scsi_driver.h +++ b/include/scsi/scsi_driver.h @@ -12,6 +12,7 @@ struct scsi_device; struct scsi_driver { struct device_driver gendrv; + void (*sync)(struct device *); void (*rescan)(struct device *); int (*init_command)(struct scsi_cmnd *); void (*uninit_command)(struct scsi_cmnd *); Bart.��.n��������+%������w��{.n�����{���fk��ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f
