Thank you, Rohit Zambre On Thu, May 17, 2018 at 8:30 AM, Yishai Hadas <yishaih@xxxxxxxxxxxxxxxxxx> wrote: > On 5/14/2018 7:26 PM, Jason Gunthorpe wrote: >> >> On Thu, May 10, 2018 at 12:48:41PM +0000, Rohit Zambre wrote: >>> >>> Currently, the lock on an extended CQ is still taken even if the user >>> sets >>> the IBV_CREATE_CQ_ATTR_SINGLE_THREADED flag. This is because the >>> MLX5_CQ_FLAGS_SINGLE_THREADED flag is not set before mlx5_cq_fill_pfns. >>> >>> This patch sets the MLX5_CQ_FLAGS_SINGLE_THREADED flag after allocating >>> the extended CQ and before calling mlx5_cq_fill_pfns, allowing correct >>> control on the lock in mlx5_start_poll and mlx5_end_poll. >>> >>> Thanks, >>> Signed-off-by: Rohit Zambre <rzambre@xxxxxxx> >>> --- >>> providers/mlx5/verbs.c | 7 ++++--- >>> 1 file changed, 4 insertions(+), 3 deletions(-) >> >> >> Sure looks right to me, Yishai? >> > > Yes, it's correct, thanks. > I have opened a PR for that [1] with the matching "Fixes:" line, merged. > > [1] > https://github.com/linux-rdma/rdma-core/pull/334 > > -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
