Re: [PATCH rdma-core] Do not install mlx5 kernel headers if mlx5 is not built

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am Dienstag, den 15.05.2018, 13:29 -0600 schrieb Jason Gunthorpe:
> We don't build some providers if DMA is not supported, but we still
> installed the renamed kernel header in this case. This causes package
> builds to fail because the sed script in debian/rules will remove the
> mlx5
> stuff indiscriminately if DMA is not supported.
> 
> Simple fix is to be consistent and not include any mlx5 stuff if mlx5
> is
> not built.
> 
> Cc: stable@xxxxxxxxxxxxxx
> Signed-off-by: Jason Gunthorpe <jgg@xxxxxxxxxxxx>
> ---
>  kernel-headers/CMakeLists.txt | 1 -
>  providers/mlx5/CMakeLists.txt | 3 ++-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> Benjamin, this should fix the build failures I saw from the debian
> autobuilder..
> 
> What do you think?

Yes that is one way to fix the build failure, but it would also be okay
if you decide that you always want to install all headers.

-- 
Benjamin Drung
System Developer
Debian & Ubuntu Developer

ProfitBricks GmbH
Greifswalder Str. 207
10405 Berlin

Email: benjamin.drung@xxxxxxxxxxxxxxxx
URL: https://www.profitbricks.de

Sitz der Gesellschaft: Berlin
Registergericht: Amtsgericht Charlottenburg, HRB 125506 B
Geschäftsführer: Achim Weiss, Matthias Steinberg, Christoph Steffens
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux