Re: [PATCH] RDMA/cma: Avoid using invalid state during rdma_bind_addr()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> Am I missing something? Did it start out OK and just get broken over
> the last decade?

As far as I can see, the bug is already there in the very first CMA commit
e51060f08a61.

I'm not sure we can make id_priv state changes transactional - looks like
some of the state may be hard to roll back.  And anyway this is just
obfuscated locking, except that simultaneous operations fail rather than
wait for each other.  Maybe the right fix is just to make access to id_priv
exclusive - have every function take a per-id lock while state is changing,
so everything happens atomically if multiple threads access the same id.

  - R.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux