On Tue, 2018-05-15 at 15:28 -0500, Steve Wise wrote:
> > -----Original Message-----
> > From: linux-rdma-owner@xxxxxxxxxxxxxxx <linux-rdma-
> > owner@xxxxxxxxxxxxxxx> On Behalf Of Doug Ledford
> > Sent: Tuesday, May 15, 2018 2:53 PM
> > To: David Ahern <dsahern@xxxxxxxxx>; Steve Wise
> > <swise@xxxxxxxxxxxxxxxxxxxxx>; leon@xxxxxxxxxx
> > Cc: stephen@xxxxxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; linux-
> > rdma@xxxxxxxxxxxxxxx
> > Subject: Re: [PATCH v2 iproute2-next 1/3] rdma: update rdma_netlink.h to
> > get new driver attributes
> >
> > On Tue, 2018-05-15 at 13:37 -0600, David Ahern wrote:
> > > On 5/14/18 9:42 AM, Steve Wise wrote:
> > > > diff --git a/rdma/include/uapi/rdma/rdma_netlink.h
> >
> > b/rdma/include/uapi/rdma/rdma_netlink.h
> > > > index 60416ed..40be0d8 100644
> > > > --- a/rdma/include/uapi/rdma/rdma_netlink.h
> > > > +++ b/rdma/include/uapi/rdma/rdma_netlink.h
> > > >
> > > > @@ -387,6 +399,20 @@ enum rdma_nldev_attr {
> > > > RDMA_NLDEV_ATTR_RES_PD_ENTRY, /* nested table */
> > > > RDMA_NLDEV_ATTR_RES_LOCAL_DMA_LKEY, /* u32 */
> > > > RDMA_NLDEV_ATTR_RES_UNSAFE_GLOBAL_RKEY, /* u32 */
> > > > + /*
> > > > + * driver-specific attributes.
> > > > + */
> > > > + RDMA_NLDEV_ATTR_DRIVER, /* nested table */
> > > > + RDMA_NLDEV_ATTR_DRIVER_ENTRY, /* nested table */
> > > > + RDMA_NLDEV_ATTR_DRIVER_STRING, /* string */
> > > > + /*
> > > > + * u8 values from enum rdma_nldev_print_type
> > > > + */
> > > > + RDMA_NLDEV_ATTR_DRIVER_PRINT_TYPE, /* u8 */
> > > > + RDMA_NLDEV_ATTR_DRIVER_S32, /* s32 */
> > > > + RDMA_NLDEV_ATTR_DRIVER_U32, /* u32 */
> > > > + RDMA_NLDEV_ATTR_DRIVER_S64, /* s64 */
> > > > + RDMA_NLDEV_ATTR_DRIVER_U64, /* u64 */
> > >
> > > and again here.
> >
> > This chunk, however, is a problem. We'll need to fix that in the kernel
> > and in this patch too.
>
> I'll fix this series once I fix the kernel side. Doug, should I send a patch that basically moves the DRIVER attributes to the bottom?
>
> Sorry about missing this!
I missed it too. I knew about the first hunk, but thought this one was
at the end. Anyway, I've already pushed the fix to my wip/dl-for-next
branch, so you can get it there now.
--
Doug Ledford <dledford@xxxxxxxxxx>
GPG KeyID: B826A3330E572FDD
Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDDAttachment:
signature.asc
Description: This is a digitally signed message part
